Spring Integration channel adapter code samples #755

joaoandremartins · 2017-07-12T21:13:04Z

Aid on getting started with the Spring Integration GCP Pub/Sub channel
adapters.

Aid on getting started with the Spring Integration GCP Pub/Sub channel adapters.

joaoandremartins · 2017-07-12T21:13:45Z

@jabubake @meltsufin @artembilan can you please take a look?

jabubake

I just did a quick pass, can review in more detail early next week. Please provide a README.md

jabubake · 2017-07-13T14:33:37Z

pom.xml

@@ -89,6 +89,7 @@
        <module>pubsub/cloud-client</module>
        <module>spanner/cloud-client</module>
        <module>speech/cloud-client</module>
+        <module>spring/integration/pubsub</module>


Lets just use spring/pubsub for now

jabubake · 2017-07-13T14:34:12Z

spring/integration/pubsub/pom.xml

@@ -0,0 +1,130 @@
+<?xml version="1.0" encoding="UTF-8"?>


All the files are missing the license header.

Why XML configs should be with the License as well?
Is that your policy?
We in Spring only care about classes (Java/Groovy/Kothlin etc.)

jabubake · 2017-07-13T14:35:48Z

spring/integration/pubsub/src/main/java/com/example/spring/pubsub/PubsubApplication.java

@@ -0,0 +1,153 @@
+package com.example.spring.pubsub;


License header missing

jabubake · 2017-07-13T14:37:02Z

spring/integration/pubsub/src/main/java/com/example/spring/pubsub/PubsubApplication.java

+import com.google.cloud.pubsub.v1.AckReplyConsumer;
+import com.google.protobuf.ByteString;
+
+import java.util.List;


Please use Google Java Formatter for the source files.

jabubake · 2017-07-13T14:38:33Z

spring/integration/pubsub/src/main/java/com/example/spring/pubsub/PubsubApplication.java

+    SpringApplication.run(PubsubApplication.class, args);
+  }
+
+  @GetMapping("/listTopics")


Might be worth moving the @RestController and mappings to a different class and keeping the Application class simple (less cognitive load)

jabubake · 2017-07-13T14:39:18Z

spring/integration/pubsub/src/main/java/com/example/spring/pubsub/PubsubApplication.java

+  }
+
+  @GetMapping("/listTopics")
+  public List<String> listTopics() {


public methods : please provide a Javadoc

meltsufin

I don't think we should merge this sample until at least the snapshots of spring-cloud-gcp are published.
This code currently depends on a build from a branch of spring-cloud-gcp.

@jabubake Before we get too much into the weeds of this, is this a good concept for a sample app? I have concerns around all the Angular stuff being distracting.

Also, the UI I think needs some CSS work to make it a bit more presentable.

meltsufin · 2017-07-13T14:43:58Z

spring/integration/pubsub/pom.xml

+  <dependencies>
+    <dependency>
+      <groupId>org.springframework.cloud</groupId>
+      <artifactId>spring-cloud-gcp-core</artifactId>


You shouldn't need this. It's a transitive dependency of spring-cloud-gcp-starter-pubsub.

meltsufin · 2017-07-13T14:44:11Z

spring/integration/pubsub/pom.xml

+    </dependency>
+    <dependency>
+      <groupId>org.springframework.cloud</groupId>
+      <artifactId>spring-cloud-gcp-pubsub</artifactId>


Also not needed.

meltsufin · 2017-07-13T14:44:46Z

spring/integration/pubsub/pom.xml

+    </dependency>
+    <dependency>
+      <groupId>org.springframework.cloud</groupId>
+      <artifactId>spring-integration-gcp</artifactId>


Again, I think it's a transitive dependency of spring-cloud-gcp-starter-pubsub.

This one isn't.

meltsufin · 2017-07-13T14:59:36Z

spring/integration/pubsub/src/main/java/com/example/spring/pubsub/PubsubApplication.java

+  @ServiceActivator(inputChannel = "pubsubOutputChannel")
+  public MessageHandler messageSender(PubsubTemplate pubsubTemplate) throws IOException {
+    PubsubMessageHandler outboundAdapter = new PubsubMessageHandler(pubsubTemplate);
+    outboundAdapter.setTopic("test");


Who creates this "test" topic?

It has to have been previously created.

Maybe it's better to provide the ability to select a topic to which to post the message then?

You can't do that dynamically.

joaoandremartins · 2017-07-13T15:31:49Z

It sounds like this shouldn't be so much of a code sample, but probably be broken into pieces and added to a tutorial or getting started guide. I might do that, instead.

artembilan

Nothing critical - just a couple simple non-confusing suggestions.

artembilan · 2017-07-13T17:06:18Z

spring/integration/pubsub/src/main/java/com/example/spring/pubsub/PubsubApplication.java

+@SpringBootApplication
+@IntegrationComponentScan
+@RestController
+@ComponentScan(basePackages = {"org.springframework.cloud.gcp"})


We don't need @IntegrationComponentScan since Boot 1.5 any more.
Also it isn't clear why do you need that @ComponentScan.
If you don't see some beans from the Spring-GCP project, then some auto-configuration is missed.
Should be fixed there.

Remember META-INF/spring.factories with the entry org.springframework.boot.autoconfigure.EnableAutoConfiguration=\ ?

artembilan · 2017-07-13T17:08:05Z

spring/integration/pubsub/src/main/java/com/example/spring/pubsub/PubsubApplication.java

+
+  @Bean
+  @ServiceActivator(inputChannel = "pubsubInputChannel")
+  public MessageHandler receiveMessageInParallel() {


It's not in parallel if you don't use Executor option for the PublishSubscribeChannel

artembilan · 2017-07-13T17:09:44Z

spring/integration/pubsub/src/main/java/com/example/spring/pubsub/PubsubApplication.java

+
+  @Bean
+  public MessageChannel pubsubOutputChannel() {
+    return new PublishSubscribeChannel();


Would be much clear to determine why do we need PublishSubscribeChannel here as well.
Looks like DirectChannel is pretty enough.

Also you might consider to not declare @Bean for this channel at all - and Spring Integration will take care about channel auto-creation for you by provided name in the @ServiceActivator.

I wanted to test delivery to all subscribers, instead of round-robin, which is what I was seeing with DirectChannel.

From reading PublishSubscriberChannel Javadoc, it seems indeed that the delivery is indeed not parallel, but single-threaded. Parallelization isn't my main focus here anyway, but rather the ability to receive the sent message in multiple subscribers at a time. Maybe I should rename the methods to messageReceiver1() and messageReceiver2() or something in those lines to keep it simpler, without going into Executor details..

Really? I don't see more subscriber to this pubsubOutputChannel.
That is my concern to keep sample as simple as possible.

I agree about renaming subscribers to the pubsubInputChannel to avoid similar questions about parallelism

To your point about not needing @Bean, IIUC that's true for outbound adapters (and it appears we're already relying on @ServiceActivator to do that for us), but the inbound adapter seems to require the channel explicitly, e.g., adapter.setOutputChannel(inputChannel);.

Yeah... I don't tell anything about inbound part here.
That is fully fine, especially that you would like to get there publish-subscribe scenario.
So, yes, definitely we have to declare MessageChannel bean if we need something else rather than just plain DirectChannel.

My concern is on this line of code only about this pubsubOutputChannel bean definition.

artembilan

LGTM

joaoandremartins · 2017-07-14T18:39:43Z

We decided to turn this into a getting started guide, instead, so I'll close this one for the time being.

…1.2 (#755) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://github.com/googleapis/java-cloud-bom)) | `26.1.1` -> `26.1.2` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.2/compatibility-slim/26.1.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.2/confidence-slim/26.1.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-tasks).

…uration to v1.2.0 (#755) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud.samples:shared-configuration](https://github.com/GoogleCloudPlatform/java-repo-tools) | `1.0.23` -> `1.2.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud.samples:shared-configuration/1.2.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud.samples:shared-configuration/1.2.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud.samples:shared-configuration/1.2.0/compatibility-slim/1.0.23)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud.samples:shared-configuration/1.2.0/confidence-slim/1.0.23)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>GoogleCloudPlatform/java-repo-tools</summary> ### [`v1.2.0`](https://github.com/GoogleCloudPlatform/java-repo-tools/compare/v1.0.24...v1.2.0) [Compare Source](https://github.com/GoogleCloudPlatform/java-repo-tools/compare/v1.0.24...v1.2.0) ### [`v1.0.24`](https://github.com/GoogleCloudPlatform/java-repo-tools/compare/v1.0.23...v1.0.24) [Compare Source](https://github.com/GoogleCloudPlatform/java-repo-tools/compare/v1.0.23...v1.0.24) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-vision).

### Migrating samples from [googleapis/java-vision](https://github.com/googleapis/java-vision/tree/main/samples) into [java-docs-samples/vision](https://github.com/GoogleCloudPlatform/java-docs-samples) --- - samples: Vision v1p1beta1 samples (#951) - samples: IoT MQTT Tests (#966) - samples: Generalized testDetextWebEntitiesIncludeGeoResults. (#976) - samples: Update of Flexible folder and the top-level parent pom. (#1004) - samples: Fix tests due to backend changes (#1081) - samples: Add vision ocr for pdf/tiff (#1078) - samples: Update vision dependency version and fix test. (#1099) - samples: Vision beta samples (#1154) - samples: Vision region tag update (#1182) - samples: Udpate Beta Vision samples to use beta tags (#1184) - samples: Remove unused Vision samples and region tags (#1208) - samples: Beta feature : Vision : PDF/TIFF/GIF document feature detection (#1349) - samples: vision: address flakes due to collisions. (#1458) - samples: Fix failing beta tets (#1592) - feat: make repo releasable, add parent/bom (#1) - chore: update common templates, regenerate tests (#20) - chore(regen): update license year for generated files (#48) - samples: fix generated samples directory (#70) - samples: add scaffold (#84) - chore(deps): update dependency com.google.cloud:libraries-bom to v4.3.0 (#88) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.13 (#92) - samples: docs: update tests that are failing or not cleaning up resources - samples: update shared config (#2443) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.14 (#96) - chore(deps): update dependency com.google.cloud:libraries-bom to v4.4.0 (#97) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.15 (#100) - chore(deps): update dependency com.google.cloud:libraries-bom to v4.4.1 (#101) - chore(deps): update dependency com.google.cloud:libraries-bom to v5 (#110) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.16 (#115) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.17 (#121) - chore(deps): update dependency com.google.cloud:libraries-bom to v5.2.0 (#125) - chore(deps): update dependency com.google.cloud:libraries-bom to v5.3.0 (#129) - chore(deps): update dependency com.google.cloud:libraries-bom to v5.4.0 (#139) - chore(deps): update dependency com.google.cloud:libraries-bom to v5.6.0 (#149) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.18 (#155) - chore(deps): update dependency com.google.cloud:libraries-bom to v5.7.0 (#157) - chore(deps): update dependency com.google.cloud:libraries-bom to v6 (#162) - chore(deps): update dependency com.google.cloud:libraries-bom to v7 (#168) - chore(deps): update dependency com.google.cloud:libraries-bom to v7.0.1 (#176) - chore(deps): update dependency com.google.cloud:libraries-bom to v7.0.2 (#178) - chore(deps): update dependency com.google.cloud:libraries-bom to v8 (#179) - chore(deps): update dependency com.google.cloud:libraries-bom to v8.1.0 (#188) - samples: Cloud Client Vision How-to snippets (#485) - samples: Adds GCS snippets, was blocked by https://goo.gl/uWgYhQ - samples: Fixes checkstyle, 3P libs before java libs - samples: Updates vision to the latest library (#548) - samples: Updates snippets so the API client is created in examples (#572) - samples: Infer project from env - samples: Vision speech upgrade (#641) - samples: Changes http test to point to better hosting. - samples: Use Cloud Storage bucket for web URI test - samples: Style nit - samples: Change test to public GCS bucket. - samples: Change test to environment variable. - samples: updating to latest google-cloud-* dependencies (#723) - samples: Closes image annotator client. - samples: Uses try with resource to ensure client gets closed. - samples: upgrade Guava (#802) - samples: Don't check for location (#809) - samples: Vision v1p1beta1 samples (#951) - samples: Update vision folder. (#999) - samples: Update vision/beta web detection samples to v1 (#1016) - samples: Fix tests for backend changes (#1082) - samples: Update vision dependency version and fix test. (#1099) - samples: Update OCR sample from beta to ga (#1123) - samples: Vision region tag update (#1182) - samples: Vision GA - library update (#1213) - samples: vision: address changes in vision annotations. (#1326) - samples: vision: address flakes due to collisions. (#1458) - samples: Fix failing tests (#1591) - samples: Add vision ocr set endpoint snippets (#1748) - samples: vision: change flaky tests to mocks (#2254) - samples: vision: move samples out of branch (#2298) - samples: vision: move samples out of branch and add clarifying comments (#2297) - samples: fix: region tag (#2312) - samples: vision: makes tests more generic (#2475) - samples: update shared config (#2443) - samples: chore: added comment on try/catch block (#2980) - samples: chore: splitting sample into single files (#3083) - samples: fix test dependencies - samples: fix resources - samples: Vision Product Search (#1161) - samples: Vision region tag update (#1182) - samples: Adding the Product Search tests. (#1195) - samples: Added the Product Search tests and the src file updates (#1196) - samples: Vision Product Search - GA (#1257) - samples: Pdt search updates (#1473) - samples: Purge Products (#1569) - samples: vision: update product search tests (#2378) - samples: vision: use uuid for product search tests - samples: Update ImportProductSetsIT.java - samples: bump timeouts - samples: update shared config (#2443) - samples: fix resources and dependencies - samples: fix resources - chore(deps): update dependency com.google.cloud:libraries-bom to v9 (#207) - chore(deps): update dependency com.google.cloud:libraries-bom to v9.1.0 - chore(deps): update dependency com.google.cloud:libraries-bom to v10 - chore(deps): update dependency com.google.cloud:libraries-bom to v11 - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.21 (#244) - chore(deps): update dependency com.google.cloud:libraries-bom to v12 (#249) - test(deps): update dependency junit:junit to v4.13.1 - chore(deps): update dependency com.google.cloud:libraries-bom to v12.1.0 (#262) - chore(deps): update dependency com.google.cloud:libraries-bom to v13 (#272) - test(deps): update dependency com.google.truth:truth to v1.1 (#274) - chore(deps): update dependency com.google.cloud:libraries-bom to v13.2.0 (#284) - chore(deps): update dependency com.google.cloud:libraries-bom to v13.3.0 (#287) - chore(deps): update dependency com.google.cloud:libraries-bom to v13.4.0 (#297) - chore: moving the rest of the vision samples (#291) - samples(deps): update spring.version to v2.3.5.release (#305) - chore(deps): update dependency com.google.cloud:libraries-bom to v14 (#307) - chore(deps): update dependency com.google.cloud:libraries-bom to v15 (#310) - chore(deps): update dependency com.google.cloud:libraries-bom to v16 (#326) - chore(deps): update dependency com.google.cloud:libraries-bom to v16.2.0 (#357) - chore(deps): update dependency com.google.cloud:libraries-bom to v16.2.1 (#362) - samples(deps): update dependency org.springframework.cloud:spring-cloud-gcp-dependencies to v1.2.6.release (#313) - samples(deps): update spring.version to v2.4.1 (#320) - samples(deps): update spring.version to v2.4.2 (#374) - chore(deps): update dependency com.google.cloud:libraries-bom to v16.4.0 (#373) - test(deps): update dependency junit:junit to v4.13.2 (#397) - test(samples): prevent failure in nightly run by adding retry (#392) - chore(deps): update dependency com.google.cloud:libraries-bom to v17 (#411) - samples(deps): update dependency com.google.cloud:google-cloud-core to v1.94.1 (#405) - samples(deps): update spring.version to v2.4.3 (#402) - samples(deps): update dependency org.springframework.cloud:spring-cloud-gcp-dependencies to v1.2.7.release (#395) - chore(deps): update dependency com.google.cloud:libraries-bom to v18 (#414) - deps: update dependency com.google.cloud:google-cloud-core to v1.94.2 (#423) - chore(deps): update dependency com.google.cloud:libraries-bom to v18.1.0 (#427) - chore(deps): update dependency com.google.cloud:libraries-bom to v19 (#431) - deps: update dependency com.google.cloud:google-cloud-core to v1.94.3 (#428) - chore(deps): update dependency com.google.cloud:libraries-bom to v19.1.0 (#445) - chore(deps): update dependency com.google.cloud:libraries-bom to v19.2.1 (#447) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.22 (#454) - chore(deps): update dependency com.google.cloud:libraries-bom to v20 (#463) - deps: update dependency net.sourceforge.argparse4j:argparse4j to v0.9.0 (#455) - deps: update dependency com.google.cloud:google-cloud-core to v1.94.7 (#441) - deps: update spring.version to v2.4.4 (#448) - deps: update spring.version to v2.4.5 (#474) - chore(deps): update dependency com.google.cloud:libraries-bom to v20.1.0 (#475) - chore: service throttles on public URLs & its known issue. (#477) - deps: update dependency com.google.cloud:google-cloud-core to v1.94.8 (#482) - chore(deps): update dependency com.google.cloud:libraries-bom to v20.2.0 (#487) - chore(deps): update dependency com.google.cloud:libraries-bom to v20.3.0 (#500) - test(deps): update dependency com.google.truth:truth to v1.1.2 (#498) - deps: update dependency org.springframework.cloud:spring-cloud-gcp-dependencies to v1.2.8.release (#497) - chore(deps): update dependency com.google.cloud:libraries-bom to v20.4.0 (#509) - test(deps): update dependency com.google.truth:truth to v1.1.3 (#520) - chore(deps): update dependency com.google.cloud:libraries-bom to v20.5.0 (#519) - deps: update spring.version to v2.5.0 (#516) - chore(deps): update dependency com.google.cloud:libraries-bom to v20.6.0 (#537) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.23 (#536) - deps: update dependency com.google.cloud:google-cloud-core to v1.95.1 (#533) - deps: update dependency com.google.cloud:google-cloud-core to v1.95.2 (#542) - deps: update spring.version to v2.5.1 (#544) - chore(deps): update dependency com.google.cloud:libraries-bom to v20.7.0 (#564) - deps: update spring.version to v2.5.2 (#566) - deps: update dependency com.google.cloud:google-cloud-core to v1.95.4 (#563) - chore(deps): update dependency com.google.cloud:libraries-bom to v20.8.0 (#575) - chore(deps): update dependency com.google.cloud:libraries-bom to v20.9.0 (#586) - deps: update dependency com.google.cloud:google-cloud-core to v2 (#599) - deps: update dependency org.apache.commons:commons-csv to v1.9.0 (#598) - deps: update dependency com.google.cloud:google-cloud-core to v2.0.3 (#611) - deps: update dependency com.google.cloud:google-cloud-core to v2.0.5 (#614) - deps: update spring.version to v2.5.4 (#581) - chore(deps): update dependency com.google.cloud:libraries-bom to v21 (#619) - deps: update dependency com.google.cloud:google-cloud-core to v2.1.0 (#634) - deps: update dependency com.google.cloud:google-cloud-core to v2.1.1 (#641) - chore(deps): update dependency com.google.cloud:libraries-bom to v22 (#650) - deps: update dependency com.google.cloud:google-cloud-core to v2.1.2 (#652) - chore(deps): update dependency com.google.cloud:libraries-bom to v23 (#668) - chore: migrate to owlbot (#663) - deps: update dependency com.google.cloud:google-cloud-core to v2.1.3 (#674) - deps: update dependency com.google.cloud:google-cloud-core to v2.1.4 (#685) - deps: update dependency com.google.cloud:google-cloud-core to v2.1.6 (#692) - deps: update spring.version to v2.5.5 (#703) - deps: update dependency com.google.cloud:google-cloud-core to v2.1.7 (#702) - chore(deps): update dependency com.google.cloud:libraries-bom to v23.1.0 (#715) - deps: update dependency com.google.cloud:google-cloud-core to v2.2.0 (#720) - deps: update spring.version to v2.5.6 (#729) - chore(deps): update dependency com.google.cloud:libraries-bom to v24 (#733) - deps: update dependency com.google.cloud:google-cloud-core to v2.3.0 (#744) - deps: update dependency com.google.cloud:google-cloud-core to v2.3.1 (#746) - deps: update spring.version to v2.6.0 (#749) - deps: update dependency com.google.cloud:google-cloud-core to v2.3.2 (#756) - deps: update dependency com.google.cloud:google-cloud-core to v2.3.3 (#758) - deps: update dependency org.springframework.boot:spring-boot-starter-web to v2.6.1 (#751) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.2.0 (#755) - chore(deps): update dependency com.google.cloud:libraries-bom to v24.1.0 (#767) - chore(deps): update dependency com.google.cloud:libraries-bom to v24.1.1 (#769) - deps: update dependency com.google.cloud:google-cloud-core to v2.3.4 (#772) - chore(deps): update dependency com.google.cloud:libraries-bom to v24.1.2 (#773) - deps: update dependency com.google.cloud:google-cloud-core to v2.3.5 (#779) - chore(deps): update dependency com.google.cloud:libraries-bom to v24.2.0 (#788) - deps: update spring.version to v2.6.3 (#768) - deps: update dependency com.google.cloud:google-cloud-core to v2.4.0 (#797) - chore(deps): update dependency com.google.cloud:libraries-bom to v24.3.0 (#809) - deps: update dependency com.google.cloud:google-cloud-core to v2.5.0 (#804) - deps: update dependency com.google.cloud:google-cloud-core to v2.5.1 (#811) - deps: update dependency com.google.cloud:google-cloud-core to v2.5.3 (#812) - deps: update dependency com.google.cloud:google-cloud-core to v2.5.4 (#816) - deps: update dependency com.google.cloud:google-cloud-core to v2.5.5 (#825) - deps: update dependency com.google.cloud:google-cloud-core to v2.5.6 (#828) - chore(deps): update dependency com.google.cloud:libraries-bom to v24.4.0 (#830) - deps: update dependency org.springframework.boot:spring-boot-maven-plugin to v2.6.4 (#822) - deps: update dependency com.google.cloud:google-cloud-core to v2.5.8 (#840) - deps: update dependency com.google.cloud:google-cloud-core to v2.5.9 (#844) - chore(deps): update dependency com.google.cloud:libraries-bom to v25 (#850) - deps: update dependency com.google.cloud:google-cloud-core to v2.5.10 (#849) - deps: update spring.version to v2.6.5 (#855) - deps: update dependency com.google.cloud:google-cloud-core to v2.5.11 (#860) - chore(deps): update dependency com.google.cloud:libraries-bom to v25.1.0 (#866) - build(deps): bump spring-boot-starter-web in /samples/spring-framework (#867) - deps: update dependency com.google.cloud:google-cloud-core to v2.6.1 (#878) - deps: update spring.version to v2.6.7 (#888) - chore(deps): update dependency com.google.cloud:libraries-bom to v25.2.0 (#891) - chore(deps): update dependency com.google.cloud:libraries-bom to v25.3.0 (#905) - deps: update spring.version to v2.7.0 (#908) - deps: update dependency com.google.cloud:google-cloud-core to v2.7.1 (#906) - chore(deps): update dependency com.google.cloud:libraries-bom to v25.4.0 (#917) - deps: update dependency com.google.cloud:google-cloud-core to v2.8.0 (#920) - deps: update spring.version to v2.7.1 (#925) - deps: update dependency com.google.cloud:google-cloud-core to v2.8.1 (#931) - chore(deps): update dependency com.google.cloud:libraries-bom to v26 (#945) - deps: update spring.version to v2.7.2 (#951) - deps: update dependency com.google.cloud:google-cloud-core to v2.8.6 (#955) - deps: update dependency com.google.cloud:google-cloud-core to v2.8.7 (#958) - deps: update dependency com.google.cloud:google-cloud-core to v2.8.8 (#960) - chore(deps): update dependency com.google.cloud:libraries-bom to v26.1.0 (#970) - deps: update spring.version to v2.7.3 (#974) - deps: update dependency com.google.cloud:google-cloud-core to v2.8.9 (#973) - deps: update dependency com.google.cloud:google-cloud-core to v2.8.10 (#977) - chore(deps): update dependency com.google.cloud:libraries-bom to v26.1.1 (#978) - deps: update dependency com.google.cloud:google-cloud-core to v2.8.11 (#980) - deps: update dependency com.google.cloud:google-cloud-core to v2.8.12 (#984) - chore(deps): update dependency com.google.cloud:libraries-bom to v26.1.2 (#990) - deps: update dependency com.google.cloud:google-cloud-core to v2.8.13 (#992) - deps: update dependency com.google.cloud:google-cloud-core to v2.8.14 (#993) - deps: update spring.version to v2.7.4 (#994) - deps: update dependency com.google.cloud:google-cloud-core to v2.8.18 (#995) - deps: update dependency com.google.cloud:google-cloud-core to v2.8.19 (#1023) - deps: update dependency com.google.cloud:google-cloud-core to v2.8.20 (#1025) - chore(deps): update dependency com.google.cloud:libraries-bom to v26.1.3 (#1031) - deps: update dependency com.google.cloud:google-cloud-core to v2.8.21 (#1034) Fixes #issue > It's a good idea to open an issue first for discussion. - [ ] I have followed [Sample Format Guide](https://github.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md) - [ ] `pom.xml` parent set to latest `shared-configuration` - [ ] Appropriate changes to README are included in PR - [ ] API's need to be enabled to test (tell us) - [ ] Environment Variables need to be set (ask us to set them) - [ ] **Tests** pass: `mvn clean verify` **required** - [ ] **Lint** passes: `mvn -P lint checkstyle:check` **required** - [ ] **Static Analysis**: `mvn -P lint clean compile pmd:cpd-check spotbugs:check` **advisory only** - [ ] Please **merge** this PR for me once it is approved.

Spring Integration channel adapter code samples

6f66f37

Aid on getting started with the Spring Integration GCP Pub/Sub channel adapters.

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 12, 2017

jabubake self-requested a review July 13, 2017 14:31

jabubake reviewed Jul 13, 2017

View reviewed changes

meltsufin reviewed Jul 13, 2017

View reviewed changes

jabubake added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 13, 2017

Remove unnecessary dependencies

f13fa3c

artembilan suggested changes Jul 13, 2017

View reviewed changes

artembilan mentioned this pull request Jul 13, 2017

Adds PubsubAdmin spring-attic/spring-cloud-gcp#69

Merged

More code review fixes

431123d

artembilan approved these changes Jul 13, 2017

View reviewed changes

joaoandremartins added 2 commits July 13, 2017 15:32

Code review fixes

a06cd45

Adds README and other smaller fixes

43ef2e8

joaoandremartins closed this Jul 14, 2017

averikitsch mentioned this pull request Oct 27, 2022

migrate code from googleapis/java-tasks #7368

Merged

9 tasks

Shabirmean mentioned this pull request Nov 15, 2022

samples: migrate code from googleapis/java-vision #7428

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Spring Integration channel adapter code samples #755

Spring Integration channel adapter code samples #755

joaoandremartins commented Jul 12, 2017

joaoandremartins commented Jul 12, 2017

jabubake left a comment

jabubake Jul 13, 2017

jabubake Jul 13, 2017

artembilan Jul 13, 2017

jabubake Jul 13, 2017

jabubake Jul 13, 2017

jabubake Jul 13, 2017

jabubake Jul 13, 2017

meltsufin left a comment

meltsufin Jul 13, 2017

meltsufin Jul 13, 2017

meltsufin Jul 13, 2017

joaoandremartins Jul 13, 2017

meltsufin Jul 13, 2017 •

edited

Loading

joaoandremartins Jul 13, 2017

meltsufin Jul 13, 2017

joaoandremartins Jul 13, 2017

joaoandremartins commented Jul 13, 2017

artembilan left a comment

artembilan Jul 13, 2017

artembilan Jul 13, 2017

artembilan Jul 13, 2017

joaoandremartins Jul 13, 2017

artembilan Jul 13, 2017

joaoandremartins Jul 13, 2017

artembilan Jul 13, 2017 •

edited

Loading

artembilan left a comment

joaoandremartins commented Jul 14, 2017

Spring Integration channel adapter code samples #755

Spring Integration channel adapter code samples #755

Conversation

joaoandremartins commented Jul 12, 2017

joaoandremartins commented Jul 12, 2017

jabubake left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

meltsufin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

meltsufin Jul 13, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joaoandremartins commented Jul 13, 2017

artembilan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

artembilan Jul 13, 2017 • edited Loading

Choose a reason for hiding this comment

artembilan left a comment

Choose a reason for hiding this comment

joaoandremartins commented Jul 14, 2017

meltsufin Jul 13, 2017 •

edited

Loading

artembilan Jul 13, 2017 •

edited

Loading